show basename in source: split line #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change I would get a split with... `────────────────────────── source:/server/externa[...].cpp+130 ────` which does not tell me anything about what file I am in. now I get something like this... `─────────────── source:/server/externa[...]SendReceive.hpp+110 ────`
🤖 Coverage Update
To this point, this PR:
|
|
Looks good, but why the switch from 20 chars to 30? I wish we had comments about where that came from in the first place. Looks like the old code could have made a long line if the extension was long as well. Overall this lgtm. |
I don't see myself ever debugging in a terminal that's less than 80 columns, and I would prefer to see more of the file name if it's long. I could switch it back to 20 if it's a problem. |
🤖 Coverage Update
To this point, this PR:
|
thank you for your review. the CI is failing with I think both are setup issues, and not related to my change. Is there anything I need to do to finish this PR? |
|
Yup I saw the failures, it's not on your end. I'll be looking into that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the text shown above the source window as part of the
context_source()function.I'm working on a complex C++ project, with many directories and files.
Before this change I would get a split with...
────────────────────────── source:/server/externa[...].cpp+130 ────which does not tell me anything about what file I am in, other than its extension.
After the change, I get something like this:
─────────────── source:/server/externa[...]SendReceive.hpp+110 ────Depending on the length of the path the following may be shown:
if len(fn) <= 30elif len(basename(fn)) < 20<first 15 chars>[...]<basename><first 15 chars>[...]<last 10 chars>